Closed h0h0h0 closed 5 years ago
Merging #50 into master will increase coverage by
5.96%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 82.8% 88.77% +5.96%
==========================================
Files 38 32 -6
Lines 2175 2022 -153
==========================================
- Hits 1801 1795 -6
+ Misses 374 227 -147
Impacted Files | Coverage Δ | |
---|---|---|
talkgenerator/settings.py | 51.16% <100%> (-3.19%) |
:arrow_down: |
talkgenerator/utils.py | 62.19% <100%> (+5.19%) |
:arrow_up: |
talkgenerator/util/generator_util.py | 82.97% <0%> (+0.7%) |
:arrow_up: |
talkgenerator/util/os_util.py | 87.75% <0%> (+4.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c2ed808...190f536. Read the comment docs.
LGTM. Thomas, mind taking the lead on merge once your questions are sorted?
35 - remove flask deps and files
44 - remove aws bucket save
Files have been extracted to new project; shaun will share with team.