search

kosayoda / nvim-lightbulb

VSCode 💡 for neovim's built-in LSP.
MIT License
783 stars 27 forks source link

fix signature of code action handler #18

Closed weilbith closed 2 years ago

weilbith commented 2 years ago

The signature for LSP handler function has changed in neovim/neovim#15504. While in the past the third passed argument was the result (i.e. the actions) it is now the second. The third argument is now the context which is never nil or empty. As result the light bulb was always displayed at any location. The evaluation if there is a code action or not was simply broken.

kosayoda commented 2 years ago

Hello again, This should have been fixed in 7411586f6b431a9c49a50fa962b6d6eae25aeb20. Are you on the latest HEAD on master?

weilbith commented 2 years ago

Oh damn. I'm so sorry. Maybe I mixed a pull with a fetch or so. 🤐 Sorry for the noise. 🙈