Fix virtual text hl_mode

kosayoda / nvim-lightbulb

VSCode 💡 for neovim's built-in LSP.

MIT License

783 stars 27 forks source link

Fix virtual text hl_mode #19

Closed disrupted closed 2 years ago

disrupted commented 2 years ago

Lightbulb was using the old nvim_buf_set_virtual_text() api that doesn't apply the underlying highlight (cursorline).

I migrated to the newer nvim_buf_set_extmark() api and set hl_mode="combine"

disrupted commented 2 years ago

I'm not too sure about fixing hl_mode to combine, given the neovim default is replace. I think it would be a better idea to expose hl_mode as an option and have the default remain replace. Let me know what you think.

I mostly wanted to make it play nice with cursorline, but I have to agree that making it configurable gives the greatest freedom to the user. PR is updated

kosayoda commented 2 years ago

Thanks for the PR!