search

kosayoda / nvim-lightbulb

VSCode 💡 for neovim's built-in LSP.
MIT License
801 stars 30 forks source link

[deprecated] Use of deprecated api #24

Closed kunzaatko closed 2 years ago

kunzaatko commented 2 years ago

vim.lsp.diagnostic.get_all() is deprecated in 0.6 it should be replaced by vim.diagnostic.get() instead.

kunzaatko commented 2 years ago

You can assign it to me, but I will have time only in about 2 weeks.

kunzaatko commented 2 years ago

akinsho/bufferline.nvim#272

kosayoda commented 2 years ago

Unlike the other diagnostic utilities, vim.lsp.diagnostic.get_line_diagnostics isn't hard deprecated (no deprecation message): Source

--- Get the diagnostics by line
---
--- Marked private as this is used internally by the LSP subsystem, but
--- most users should instead prefer |vim.diagnostic.get()|.
---

As I replicate almost entirely the function calls performed by internal LSP subsystem when calling "get code action" manually, I don't see how I can use vim.diagnostic.get without essentially replicating the private methods used in the neovim codebase itself.

kunzaatko commented 2 years ago

Ok. I see. Well sorry for the false issue then.