search

kosi-libs / Kodein

Painless Kotlin Dependency Injection
https://kosi-libs.org/kodein
MIT License
3.21k stars 174 forks source link

Ktor 3 compatibility #454

Open stashymane opened 6 months ago

stashymane commented 6 months ago

I have attempted to port Kodein to Ktor 3 myself, as only two changes were required, however one test is failing: https://github.com/stashymane/Kodein/commit/89a4d60fd72ecd24d4e0cd5c2caad05660559413

image

It seems that the call pipeline is being skipped for some reason. Otherwise the update is rather simple. Here's the run for details: https://github.com/stashymane/Kodein/actions/runs/8818984587/job/24209096046

ssmtlbn commented 2 weeks ago

Since Ktor 3 is now final, is there an update on when or if it will be supported?

Burtan commented 1 week ago

I get errors with kodein 7.22.0 and ktor 3.0.0

Found interface io.ktor.server.routing.Routing, but class was expected
java.lang.IncompatibleClassChangeError: Found interface io.ktor.server.routing.Routing, but class was expected
    at org.kodein.di.ktor.ClosestKt.closestDI$lambda$2(closest.kt:32)