Added Helmfile support - Githubissues

koslib / helm-eks-action

The simplest Github Action for executing Helm commands on EKS - cluster authentication included

MIT License

61 stars 61 forks source link

Added Helmfile support #13

Closed behoof4mind closed 2 years ago

behoof4mind commented 3 years ago

Hi there! Here PR if you want to add Helmfile https://github.com/roboll/helmfile Few lines in docker and README.md updated

koslib commented 3 years ago

Hello @behoof4mind and thanks for the PR!

Some concerns I have, even though I adore Helmfile myself:

it's still in its early dev phase (hence version 0.x). As this is used by many people in prod environments, how probable is it to break their workflows?
for the majority of the users of this action who only need helm, how much overhead would that be?

I think it'd be wise to make it optional, eg. if X env variable is set, then use helmfile too. Thoughts/feedback/ideas?

behoof4mind commented 3 years ago

Hi, @koslib that's really strange that phase is still in early dev tbh. We are using helmfile for more than 3 years without any issues. Usually it is easier to operate with multiple helmcharts and variables by only one file.

Agree that it would be better to use helmfile by additional option - helmfile binary size around 45Mb. Additional build time for everyone without reason. Will check how to implement this

koslib commented 2 years ago

Closing as stale