search

koslib / helm-eks-action

The simplest Github Action for executing Helm commands on EKS - cluster authentication included
MIT License
59 stars 61 forks source link

Update GitHub Actions output syntax #54

Closed miguelaferreira closed 1 year ago

miguelaferreira commented 1 year ago

This PR updates the syntax used to create a GitHub Actions output.

Fixes #53

koslib commented 1 year ago

Hello @miguelaferreira, thanks for this PR, will make sure to take a look asap! One question though, have you practically tested this? If not no worries, I'll run a test myself anyway, just wanted a heads up :D

ps: asking bc a lot of people use this GA with @master instead of a tag and if it's untested and breaking, it might cause them issues

koslib commented 1 year ago

Ran some successful tests so merging. Fixes #48 #53

miguelaferreira commented 1 year ago

Thanks @koslib. I hadn't tested it since it's a change I'm doing in many different places and I was confident that it worked. I was going to test it now, I saw you already did. Thanks again.