search

koslib / helm-eks-action

The simplest Github Action for executing Helm commands on EKS - cluster authentication included
MIT License
62 stars 61 forks source link

Address linting warnings #59

Closed miguelaferreira closed 1 year ago

miguelaferreira commented 1 year ago

I spent some time reproducing and fixing an issue on this action, and while doing that my IDE pointed out some linting issues with the Dockerfile and the entrypoint.sh for the koslib/ga-helm-eks container image. This PR addresses those issues. I've kept each issue in a separate commit to make it easy to choose if only some commits are welcome and others not. I've also made the commits on top of the commit on my previous PR (#58). Please do let me know if any commit in this PR is not welcome, and I'll adjust accordingly.

To test this PR I created a container image (ghcr.io/miguelaferreira/ga-helm-eks:address-linting-warnings) with this code.

koslib commented 1 year ago

This looks really good, thanks @miguelaferreira, appreciate your help with this one! The changes this PR brings look good and I'll make sure to build a new base image asap! Will reporting back if something doesn't work as expected

koslib commented 1 year ago

Worked perfectly fine during testing so I merged and release v1.28.0. Thank you once again @miguelaferreira for this contribution! If you feel like you'd like to collaborate more/become a maintainer on this repo let me know!