search

kosma / minmea

a lightweight GPS NMEA 0183 parser library in pure C
Do What The F*ck You Want To Public License
755 stars 246 forks source link

Added support for GST frame #3

Closed eketh closed 10 years ago

eketh commented 10 years ago

Hey, please consider my support for GST frame.

Best regards Natalia Pyka

kosma commented 10 years ago
  1. Unit test for minmea_parse_gst is missing.
  2. A few more spelling/codingstyle comments, please fix these and we're good to merge.
eketh commented 10 years ago

Will fix that in a moment.

eketh commented 10 years ago

Fixed coding style - in case I missed some whitespaces/enters, let me know and shame on me. Also, I added unit tests for parsing (test_minmea_parse_gst1) and test scan of GPGST frames (test_minmea_scan_complex3), basing on unit tests for GPGGA.

kosma commented 10 years ago

Now, that's a good pull request! Merging. Thanks!

kosma commented 10 years ago

I had a few issues with your tests, see e2e6a41 and 6d75881. Already fixed on master.