Closed vpetrigo closed 2 years ago
This should preferably be changed to scan for any amounts and combination of \r
and \n
, like so:
while (*sentence == '\r' || *sentence == '\n')
sentence++;
if (*sentence)
return false;
Hello @cmorganBE, @kosma!
Thank you for the review. I applied suggested solution. 😅
@kosma, @cmorganBE sorry for bothering. Would you tell whether that PR can be merged?
Added tests, merged. Sorry it took so long. Thanks for the PR!
Hello,
I would like to propose a small change that allows processing of lines that end with CR only. I use tokenization of lines which are read from a GPS module with
strtok()
call with'\n
as delimiter.So that
minmea_check()
in the current implementation returns false as all lines do not end with either"\n"
or"\r\n"
.Let me know if it is applicable change.