search

kosma / minmea

a lightweight GPS NMEA 0183 parser library in pure C
Do What The F*ck You Want To Public License
791 stars 253 forks source link

Workflow #63

Closed chmorgan closed 2 years ago

kosma commented 2 years ago

One more thing: make test action is redunant since tests are already ran by make.

There's also a side problem: the workflow should fail if scan-build reports anything. I don't see any command line switch for that, however...

cmorganBE commented 2 years ago

@kosma a non-zero exit code should be doing this right now I'd imagine. Is the build passing but should be failing?

cmorganBE commented 2 years ago

@kosma this look ok now that I split the actions from that other fix?

kosma commented 2 years ago

I fixed the other thing that was pending - merged. Thanks!