Cleanup Dockerfiles a bit and added Kubernetes Deployment

kosmas58 / pia-docker

Killian Kemps (https://github.com/KillianKemps) has created an awesome Docker configuration to setup a Docker environment for production purpose. Thanks to Killian it is much easier now to run PIA. A simple docker-compose up does everything and gives a running website : front-end, back-end and database.

GNU General Public License v3.0

37 stars 34 forks source link

Cleanup Dockerfiles a bit and added Kubernetes Deployment #7

Closed Zwordi closed 5 years ago

Zwordi commented 5 years ago

Hi,

I would like to add my 2cents to this repository instead of maintaining my own fork. So:

Add the ENV VARIABLES ENV RAILS_SERVE_STATIC_FILES=true to the back in order to have it working (find on latest issue on the pia repository)
I made some cleanup on the dockerfiles to try to leverage a bit her sizer
Added a Kubernetes folder with instruction about how to deploy pia-back/front into a kubernetes cluster. I tried to put enough explication on the readme about how to do it.

What do you think ?

gbonnefille commented 5 years ago

Perhaps can you split this contribution in two separated pull-request:

one for improving Dockerfile (and moving to 2.0.0)
one for bringing K8S capabilities

gbonnefille commented 5 years ago

Oups... seems already done: 866a369b86e1badbecd1cd6016ae822fb564759e

Zwordi commented 5 years ago

Seems so :)

kosmas58 commented 5 years ago

@gbonnefille

Since Docker released the 2.x version I had issues with kubernetes on my machine.

Now I've installed the lastest Edge release of Docker and kubernetes is running again.

Now I'm able to approve your changes.

kosmas58 commented 5 years ago

First created a branch kubernetes. I need some extra time to investigate your stuff. Many thanks for your contribution.

gbonnefille commented 5 years ago

First created a branch kubernetes. I need some extra time to investigate your stuff. Many thanks for your contribution.

Yes, great to create a dedicated branch.

Zwordi commented 5 years ago

I'm available for any question event by pm if you need.