search

kosmos-io / kosmos

The limitless expansion of Kubernetes. Make Kubernetes without boundaries
https://kosmos-io.github.io/kosmos-website/
Apache License 2.0
206 stars 48 forks source link

kosmosctl install/join can set specific images (version) #125

Closed kuangcheng66 closed 11 months ago

kuangcheng66 commented 1 year ago

**Why would you like to propose this issue

  1. During the kosmos deployment test last week, I found that there was a problem with the latest v0.1.7 floter image. The problem can only be solved by specifying the v0.1.1 version of the floter image. In the future, I hope to specify a specific image when deploying kosmos ( Version);
  2. In offline deployment, upload the image to a machine that cannot connect to the external network, and then directly specify different versions of the image.

What would you like to be added: for example:

./kosmosctl join cluster 
--name=A 
--cluster-kubeconfig=[A-kubeconfig] 
--cni=[cni, e.g "calico"] 
--default-nic=[nic, e.g "eth0"]
--private-image-registry=registry.paas/cmss/kosmos-io
--image-version=0.1.7

Why is this needed:

kuangcheng66 commented 1 year ago

/assign @kuangcheng66

ONE7live commented 1 year ago

--clusterlink-floater-version change to --version? Because it is a bit complicated to use, I think we can control which images this version is used for in the code，what do you think?

kuangcheng66 commented 1 year ago

--clusterlink-floater-version change to --version? Because it is a bit complicated to use, I think we can control which images this version is used for in the code，what do you think?

Yes, we still have to discuss this issue

kuangcheng66 commented 11 months ago

/close

kosmos-robot commented 11 months ago

@kuangcheng66: Closing this issue.

In response to [this](https://github.com/kosmos-io/kosmos/issues/125#issuecomment-1839840880): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.