search

kosmos-io / kosmos

The limitless expansion of Kubernetes. Make Kubernetes without boundaries
https://kosmos-io.github.io/website/
Apache License 2.0
199 stars 47 forks source link

refactor: add workflow for node controller #492

Closed OrangeBao closed 4 months ago

OrangeBao commented 4 months ago

What type of PR is this?

/kind refactor

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
kosmos-robot commented 4 months ago

@OrangeBao: The label(s) kind/refactor cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kosmos-io/kosmos/pull/492): > > >#### What type of PR is this? > > >/kind refactor > >#### What does this PR do? > > >#### Which issue(s) does this PR fix? > >Fixes # >#### Special notes for your reviewer: > > >#### Does this PR introduce a user-facing change? > >```release-note >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
OrangeBao commented 4 months ago

/lgtm

kosmos-robot commented 4 months ago

@OrangeBao: you cannot LGTM your own PR.

In response to [this](https://github.com/kosmos-io/kosmos/pull/492#issuecomment-2078140877): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
OrangeBao commented 4 months ago

/lgtm

kosmos-robot commented 4 months ago

@OrangeBao: you cannot LGTM your own PR.

In response to [this](https://github.com/kosmos-io/kosmos/pull/492#issuecomment-2078200630): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
duanmengkk commented 4 months ago

/lgtm /approve

kosmos-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, OrangeBao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kosmos-io/kosmos/blob/main/OWNERS)~~ [OrangeBao,duanmengkk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment