kossiitkgp / KWoC-Frontend

Frontend Repo for Kharagpur Winter of Code, built in React
https://kwoc.kossiitkgp.org/
GNU General Public License v3.0
21 stars 40 forks source link

Added accordian to the FAQ page Issue #222 #224

Closed mendacium-a11y closed 9 months ago

mendacium-a11y commented 9 months ago

Fixes issue #222

https://github.com/kossiitkgp/KWoC-Frontend/assets/110321699/e267a3d8-9e1e-4b27-8746-b8d2fd9f044a

vercel[bot] commented 9 months ago

@mendacium-a11y is attempting to deploy a commit to the kossiitkgp Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kwoc-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 4:43pm
harshkhandeparkar commented 9 months ago

@mendacium-a11y can you add a background color or something to mark the difference between each FAQ element?

mendacium-a11y commented 9 months ago

I wanted to do that, just didn't know what colors to go with, perhaps something keeping with the theme of the website

harshkhandeparkar commented 9 months ago

I wanted to do that, just didn't know what colors to go with, perhaps something keeping with the theme of the website

You can try the background colors of cards used in the dashboard or anywhere else.

mendacium-a11y commented 9 months ago

I wanted to do that, just didn't know what colors to go with, perhaps something keeping with the theme of the website

You can try the background colors of cards used in the dashboard or anywhere else.

same color for the question and answer or different?

mendacium-a11y commented 9 months ago

@harshkhandeparkar could you take a look at the current colour scheme?

harshkhandeparkar commented 9 months ago

@mendacium-a11y the title color looks fine but the body color looks a bit too light for the text.

harshkhandeparkar commented 9 months ago

image Also the links are very hard to read.

mendacium-a11y commented 9 months ago

image how does this look? image perhaps something darker? but i don't think this keeps in with the theme of the website

@harshkhandeparkar

mendacium-a11y commented 9 months ago

@mendacium-a11y the title color looks fine but the body color looks a bit too light for the text.

what do you mean by title and body here?

mendacium-a11y commented 9 months ago

@harshkhandeparkar any input?

harshkhandeparkar commented 9 months ago

@mendacium-a11y the title color looks fine but the body color looks a bit too light for the text.

what do you mean by title and body here?

By title I meant the clickable element of the accordion.

harshkhandeparkar commented 9 months ago

image how does this look? image perhaps something darker? but i don't think this keeps in with the theme of the website

@harshkhandeparkar

I think both look fine, second one is probably better though.

mendacium-a11y commented 9 months ago

i've pushed the second styling code

mendacium-a11y commented 9 months ago

https://github.com/kossiitkgp/KWoC-Frontend/assets/110321699/84a76a98-dac0-4ffa-9363-fdb897c6c9b5

this how it looks now

harshkhandeparkar commented 9 months ago

Thank you @mendacium-a11y! :rocket:

mendacium-a11y commented 9 months ago

Thank you @mendacium-a11y! 🚀

happy to help