kossiitkgp / KWoC-Frontend

Frontend Repo for Kharagpur Winter of Code, built in React
https://kwoc.kossiitkgp.org/
GNU General Public License v3.0
21 stars 40 forks source link

added-types #225

Open pratham-srivastava-07 opened 9 months ago

pratham-srivastava-07 commented 9 months ago

Added types to the frontend project.

vercel[bot] commented 9 months ago

@pratham-srivastava-07 is attempting to deploy a commit to the kossiitkgp Team on Vercel.

A member of the Team first needs to authorize it.

pratham-srivastava-07 commented 9 months ago

please clarify where I have to revert the changes...would be helpful.

harshkhandeparkar commented 9 months ago

I think you have misunderstood the issue. We are extremely sorry since we did not explain it properly. We were referring the Backend endpoint types defined here. We wanted to add types for the remaining endpoints.

pratham-srivastava-07 commented 9 months ago

okay...so should I try this one more time properly?

harshkhandeparkar commented 9 months ago

okay...so should I try this one more time properly?

Sure! Sorry for the inconvenience.

pratham-srivastava-07 commented 9 months ago

so just for confirmation changes only have to be done in types.ts?

harshkhandeparkar commented 9 months ago

so just for confirmation changes only have to be done in types.ts?

Yes.

pratham-srivastava-07 commented 9 months ago

can we have a quick sync up on meet? @harshkhandeparkar

harshkhandeparkar commented 9 months ago

can we have a quick sync up on meet? @harshkhandeparkar

What do you want to discuss?

pratham-srivastava-07 commented 9 months ago

i am still having problems understanding what exactly needs to be done

harshkhandeparkar commented 9 months ago

i am still having problems understanding what exactly needs to be done

Are you familiar with the KWoC Backend API endpoints? We have a wrapper function in the frontend that makes an API request and returns the result, and it maps every endpoint to its return type. But some endpoint types are still not present in the frontend. Adding them was the issue.

pratham-srivastava-07 commented 9 months ago

okay

harshkhandeparkar commented 9 months ago

This is not a huge priority. We do keep adding types as the need arises. If you don't feel comfortable continuing with this, it is fine. Other issues are always open :)

pratham-srivastava-07 commented 9 months ago

okay will try one more time...if thats okay

harshkhandeparkar commented 9 months ago

okay will try one more time...if thats okay

Sure