search

kossiitkgp / KWoC-Frontend

Frontend Repo for Kharagpur Winter of Code, built in React
https://kwoc.kossiitkgp.org/
GNU General Public License v3.0
21 stars 40 forks source link

Sort feature on students stats not working #75

Closed sidkhuntia closed 2 years ago

sidkhuntia commented 2 years ago

Screen Shot 2021-12-11 at 17 22 44

sidkhuntia commented 2 years ago

Can i work on it ? @sahil-shubham @chirag828049

chirag-ghosh commented 2 years ago

Sure go ahead.

sahil-shubham commented 2 years ago

@sidkhuntia This was done intentionally, we don't want open source contributions to be competitive as the number of commits is not always proportional to how much work someone has put in.

What we can do is remove the line "you can sort the rows by clicking on the headers" and write a single line explanation of why we choose to sort the stats table. You are free to make a PR with this change. We can also remove the sorting on header click then.

Closing this issue.

sidkhuntia commented 2 years ago

Okay.

@sahil-shubham will something like this work? Stats are shuffled to avoid competition as open source is about contributing.

sahil-shubham commented 2 years ago

@sidkhuntia Sounds good, make a pull request and I will merge it. We can remove the sorting functionality as well as all it does is shuffle again.

sidkhuntia commented 2 years ago

@sahil-shubham i have created a PR, please check. sorry for the trouble

sahil-shubham commented 2 years ago

sorry for the trouble

There was no trouble at all, your concern for creating the issue was understandable.