search

kossiitkgp / docs

KOSS Documentation | A handbook of guidelines, principles and archives
MIT License
19 stars 6 forks source link

Create elastic-search.md #12

Closed thealphadollar closed 5 years ago

thealphadollar commented 5 years ago

Add brief details about ElasticSearch Event

Notes:

Write path(s) which will be affected by this Pull Request. Example:

Justify your changes or addition.

Why do you think it should be documented?

Will sharing this with just the current members serve our purpose? For example, how you plan to conduct an event next week is a private affair. But, how you generally do the event, should be documented.

welcome[bot] commented 5 years ago

💖 Thanks for opening this pull request! 💖

Please read our contributing guidelines thoroughly and make sure you follow it.

If you are making any changes to any written content of KOSS Documentation -

OrkoHunter commented 5 years ago

Closes #11

thealphadollar commented 5 years ago

It doesn't matter in markdown.

On Sun 7 Apr, 2019, 17:58 Ayush Kaushal, notifications@github.com wrote:

@Ayushk4 commented on this pull request.

In events/elastic-search.md https://github.com/kossiitkgp/docs/pull/12#discussion_r272832393:

@@ -0,0 +1,17 @@ +# ElasticSearch, You Know For Search + +## What was the event about? + +Aravind Putrevu, a developer advocate for Elastic, gave a talk on the rising usage of ElasticSearch and also presented a demo +on how easy it is to setup and run.

Newline?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/docs/pull/12#pullrequestreview-223580787, or mute the thread https://github.com/notifications/unsubscribe-auth/AfStIAaYxIOyG4JtENpfPKbUESAP4RQtks5veeSCgaJpZM4cgtL5 .

xypnox commented 5 years ago

It doesn't matter in markdown.

But it is done mostly after finishing a complete sentence, like after a period or a comma.

thealphadollar commented 5 years ago

Here I have done it so as to maintain the line short enough for editing; it is not comfortable to edit very long single line.

OrkoHunter commented 5 years ago

Wow! I loved the new suggestions-review feature of GitHub which I used here for the first time. You can just suggest the replacement code and the author only has to click to approve it! (You can make changes too if you have permission). Super cool!

https://help.github.com/en/articles/incorporating-feedback-in-your-pull-request#applying-a-suggested-change

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.