Added Instructions for step 1 & 2 and made the challenge code striaghtforward

kossiitkgp / email-to-slack

A hack to read emails on a slack channel while staying in free plan

40 stars 25 forks source link

Added Instructions for step 1 & 2 and made the challenge code striaghtforward #6

Closed xypnox closed 5 years ago

xypnox commented 5 years ago

I have added detailed instructions for steps 1 & 2 and a simple english explanation of what the bot does and how to make it work.

Moreover, I have moved the challenege condition above and put it in a conditional. It makes it easier to setup the app since less manual work is required. I had this problem in the beginning hence there are so many "verify *" commits.

pep8speaks commented 5 years ago

Hello @xypnox! Thanks for updating the PR.

In the file app.py, following are the PEP8 issues :

Line 30:1: W293 blank line contains whitespace Line 58:9: E303 too many blank lines (2) Line 61:80: E501 line too long (96 > 79 characters) Line 71:80: E501 line too long (126 > 79 characters)

Comment last updated on January 26, 2019 at 16:12 Hours UTC

OrkoHunter commented 5 years ago

Great! Merge it.

xypnox commented 5 years ago

Great! Merge it.

Can't. Not a collaborator :cry:

OrkoHunter commented 5 years ago

Added the team!