search

kossiitkgp / kwoc-2016

Website for Kharagpur Winter of Code 2016
https://kwoc2016.kossiitkgp.in/
8 stars 12 forks source link

Github handle made optional #20

Closed Parth-Vader closed 7 years ago

Parth-Vader commented 7 years ago

Github handle made optional in the form.

OrkoHunter commented 7 years ago

@nitinkgp23 @DefCon-007 Is it optional in flask?

DefCon-007 commented 7 years ago

@OrkoHunter I have to make the change in the database. And no checking is done on the flask side it just pushes data. Also, I think after keeping the GitHub handle optional a simple message asking the user to register on GitHub will look good.

OrkoHunter commented 7 years ago

Agreed. Something like Optional, but recommended ?

DefCon-007 commented 7 years ago

Yes and are we making a login interface ?

OrkoHunter commented 7 years ago

Did not get you.

DefCon-007 commented 7 years ago

Like a "Student" can log in to edit details and maybe check few things. The main aim will be to add GitHub handle later.

OrkoHunter commented 7 years ago

That might be tricky. We'll simply keep it contact us basis. Write an email and we'll add/fix it.

OrkoHunter commented 7 years ago

Also, instead of handle, please write username in placeholder.

DefCon-007 commented 7 years ago

Don't you that's a hectic thing. What say we keep it mandatory because GitHub account IS mandatory for KWoC. Lets give instructions to register on GitHub if someone leaves it blank

Parth-Vader commented 7 years ago

@OrkoHunter Should I also add (Optional, but recommended)?

OrkoHunter commented 7 years ago

Okay so added a link to sign up beside the text box or under it referencing https://github.com/join?source=header-home

OrkoHunter commented 7 years ago

@Parth-Vader No, just change it to GitHub username and read my last comment.

DefCon-007 commented 7 years ago

We can show that link only when someone leaves that field blank

OrkoHunter commented 7 years ago

That too.

DefCon-007 commented 7 years ago

Ok updating the issue