search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Changed the timeline colors #117

Closed nikhilch23 closed 5 years ago

nikhilch23 commented 5 years ago

Please review @xypnox #116

xypnox commented 5 years ago

LGTM, @nikhilch23 However could you try using a dark purple color? Something that matches the background? or a Vibrant color? There is now too much contrast :laughing:

nikhilch23 commented 5 years ago

But IMHO, the page is all black and white, adding a vibrant color would make it offtone. To reduce the contrast should i reduce the black color shade to bit lighter?

nikhilch23 commented 5 years ago

@xypnox

xypnox commented 5 years ago

Yeah That would be better, use a dark grey color

thealphadollar commented 5 years ago

@nikhilch23 It's always a good idea to put in a screenshot when sending design changes so that the reviewer need not fetch your PR and run it locally.