search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Tag_Scrapper capitalized first letter in node names #122

Closed shreyas-kowshik closed 5 years ago

Ayushk4 commented 5 years ago

LGTM Otherwise!

arnav-t commented 5 years ago

@Ayushk4 I haven't run the whole thing but the generate_statistics.py doesn't throw an error if the __file__ path is used.

arnav-t commented 5 years ago

@Ayushk4 fixed path issues in job_scheduler.py Please review.

Ayushk4 commented 5 years ago

@arnav-t @thealphadollar Please test the tag_scrapper.

Ayushk4 commented 5 years ago

@thealphadollar @arnav-t Test this before merging. Check for capitalized HTML and CSS tags in Kronos to confirm.

thealphadollar commented 5 years ago

@shreyas-kowshik Please put description in the PRs so that I can know what all issues it aims at fixing :+1: Thank you for the PR.

thealphadollar commented 5 years ago

@shreyas-kowshik If this was your first PR, I highly recommend reading https://blog.github.com/2015-01-21-how-to-write-the-perfect-pull-request/

This helped me a lot, and I still read it before sending PRs to see if I'm doing something wrong.

shreyas-kowshik commented 5 years ago

@thealphadollar Thanks! I'll look through it.