search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Fixes dashboard styling #136 #138

Closed themousepotato closed 5 years ago

themousepotato commented 5 years ago

fixes #136

Ayushk4 commented 5 years ago

@themousepotato Have you tested the changes locally?

xypnox commented 5 years ago

I have tested them and this is a preview of how it looks:

screenshot

themousepotato commented 5 years ago

I don't think that should be capitalized. There are other occurrences in new lines. Chill be! Please merge and deploy this ASAP. The dashboard looks ugly now.

On Thu, Dec 6, 2018 at 8:12 PM Ayush Kaushal notifications@github.com wrote:

@Ayushk4 commented on this pull request.

In templates/dashboard.html https://github.com/kossiitkgp/kwoc/pull/138#discussion_r239477664:

@@ -76,14 +76,17 @@

{{ id }}

{{ college }}




  • Projects Released!
    Go through the details and start contacting respective mentors.

    More projects are on their way...

  • Projects Released!
    Go through the details and start contacting respective mentors.

    We've updated the projects. Go check 'em out.

@themousepotato https://github.com/themousepotato Since check 'em out appears on different line, can you capitalize the first letter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/138#pullrequestreview-182270621, or mute the thread https://github.com/notifications/unsubscribe-auth/AgXlPi7uVw7OOFjYXtWU6gL_9EaBr1ACks5u2SzigaJpZM4ZGgdp .

xypnox commented 5 years ago

I don't think that should be capitalized. There are other occurrences in new lines. Chill be! Please merge and deploy this ASAP. The dashboard looks ugly now. … On Thu, Dec 6, 2018 at 8:12 PM Ayush Kaushal @.**> wrote: @Ayushk4* commented on this pull request. ------------------------------ In templates/dashboard.html <#138 (comment)>: > @@ -76,14 +76,17 @@

{{ id }}

{{ college }}




-

Projects Released!
Go through the details and start contacting respective mentors.

More projects are on their way...

+

Projects Released!
Go through the details and start contacting respective mentors.

We've updated the projects. Go check 'em out.

@themousepotato https://github.com/themousepotato Since check 'em out appears on different line, can you capitalize the first letter? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#138 (review)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AgXlPi7uVw7OOFjYXtWU6gL_9EaBr1ACks5u2SzigaJpZM4ZGgdp .

I agree