search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

fixes #147 #149

Closed themousepotato closed 5 years ago

themousepotato commented 5 years ago

@thealphadollar @yashrsharma44 @TheLethalCode I haven't tested this. This is a quick explicit fix. Will work for now. What we were doing was checking whether the auth has got a valid response from GitHub but, we weren't feeding jinja a bool var of user existence in the JSON. I have set g.ghname = "Login" to make the auth inactive on /student_registration.

thealphadollar commented 5 years ago

Why? It is good to have ghname as user on the page. Is there no other way, we can wait and get a better fix.

themousepotato commented 5 years ago

Another way is making present_flag as global and feeding it to jinja. But, that will make the same changes. It will be a permanent fx tho.

thealphadollar commented 5 years ago

It would be preferable and also we want to display separate pages for registered and unregistered users on the registration page.

On Tue 11 Dec, 2018, 17:28 Navaneeth Suresh <notifications@github.com wrote:

Another way is making present_flag as global and feeding it to jinja. But, that will make the same changes. It will be a permanent fx tho.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/149#issuecomment-446177518, or mute the thread https://github.com/notifications/unsubscribe-auth/AfStIBWjr0x-nkWRUjOKduHp5PeCR6cHks5u353cgaJpZM4ZNPtk .

themousepotato commented 5 years ago

@thealphadollar check https://github.com/kossiitkgp/kwoc/pull/149/commits/ec56e30ac6a2e407fd2275ca8a82a5fc1d71d9b2

thealphadollar commented 5 years ago

Meanwhile, work on a better fix.

themousepotato commented 5 years ago

@thealphadollar Abe have you tested this? I tried testing it on server. It's not working :disappointed:

thealphadollar commented 5 years ago

Yup!