search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Added share button to stats and dashboard #156

Closed xypnox closed 5 years ago

xypnox commented 5 years ago

Added sharing buttons for FB twitter and linked in. The buttons use urls rather than JS and this needs to be pushed to the server to test the urls correctly.

Here is a video of the same:

https://i.imgur.com/8VAJZHq.mp4

xypnox commented 5 years ago

Needless to say, this has been optimized for mobile.

xypnox commented 5 years ago

And here is a screenshot with full stats, It's similar in dashboard as well

screenshot_2018-12-12 kharagpur winter of code statistics aditya 2

thealphadollar commented 5 years ago

LGTM! Can you please change that text which says "pull requests opened" to PRs merged in both dashboard.html and profile.html?

I could do this but phir @arnav-t bolega commit badha rha hu :stuck_out_tongue_closed_eyes:

xypnox commented 5 years ago

Is this fine?

screenshot_2018-12-12 kharagpur winter of code statistics aditya 3

thealphadollar commented 5 years ago

"Pull request merged" we are no more showing closed ones, just merged ones

On Wed 12 Dec, 2018, 15:24 Aditya <notifications@github.com wrote:

Is this fine?

[image: screenshot_2018-12-12 kharagpur winter of code statistics aditya 3] https://user-images.githubusercontent.com/25076171/49861501-fa35b600-fe21-11e8-9f6e-6cc57338d0e6.png

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/156#issuecomment-446528290, or mute the thread https://github.com/notifications/unsubscribe-auth/AfStIFfUFLJC9BXe1irJ9nKA6ZtvZdgZks5u4NJNgaJpZM4ZPDVk .

xypnox commented 5 years ago

@thealphadollar I have updated the fonts and centered the headings of stats.

xypnox commented 5 years ago

@thealphadollar Changed closed to merged