search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Mid term evaluation form submit once per student #182

Closed TheLethalCode closed 5 years ago

TheLethalCode commented 5 years ago

The program reads from a file 'secrets/midterm_eval_stud.txt' for the github user names that have already submitted their midterm eval reports. I personally don't see the point of not rendering the mid_term link in the dashboard, if the user has already registered, because they are anyway redirected to the main page if that is the case. @themousepotato @thealphadollar

thealphadollar commented 5 years ago

Not rendering will be aesthetically better; showing that they've filled the form.

On Fri 21 Dec, 2018, 19:10 Kousshik Raj <notifications@github.com wrote:

The program reads from a file 'secrets/midterm_eval_stud.txt' for the github user names that have already submitted their midterm eval reports. I personally don't see the point of not rendering the mid_term link in the dashboard, if the user has already registered, because they are anyway redirected to the main page if that is the case. @themousepotato https://github.com/themousepotato @thealphadollar https://github.com/thealphadollar

You can view, comment on, or merge this pull request online at:

https://github.com/kossiitkgp/kwoc/pull/182 Commit Summary

  • Mid term evaluation, submit once

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/182, or mute the thread https://github.com/notifications/unsubscribe-auth/AfStIFJsIWCKBjmFqHSihnnLLhD_9tuGks5u7OTrgaJpZM4ZeACs .

themousepotato commented 5 years ago

@TheLethalCode Please don't send PRs from master -_-

TheLethalCode commented 5 years ago

I guess, but that is not necessary for it to be up and running. We can focus on more important issues

TheLethalCode commented 5 years ago

Yeah

On Sat, Dec 22, 2018, 12:51 Shivam Kumar Jha <notifications@github.com wrote:

@thealphadollar commented on this pull request.

In kwoc/app.py https://github.com/kossiitkgp/kwoc/pull/182#discussion_r243728664:

with open(stats_json, 'r') as f: stats_dict = json.load(f)

stats_dict = {}

+try:

What is this for? Creating the file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/182#pullrequestreview-187583307, or mute the thread https://github.com/notifications/unsubscribe-auth/Af2hEaTxPVD-yHPlkIIh4iZfjOykOcKzks5u7d1dgaJpZM4ZeACs .

thealphadollar commented 5 years ago

CHanges of this PR has been added manually in #183