Mideval link - Githubissues

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018

https://kwoc.kossiitkgp.org

MIT License

0 stars 0 forks source link

Mideval link #183

Closed xypnox closed 5 years ago

xypnox commented 5 years ago

I have done the following changes:

When the mentor matches are stored, an file named midevals_validation.json in gh_scrapper stores the github ids of students wh have filled the form.
This file is used to check if a students' dashboard should display the link as Available or diabled
Manually accessing the /mid-evals also checks the guthub ids for the same

To test:

[ ] Whether the github ids are stored properly in the file after filling the form

xypnox commented 5 years ago

This PR handles #180 #174

thealphadollar commented 5 years ago

Have you tested it?

xypnox commented 5 years ago

I have tested the dashboard and direct links. Only the testing of saving the ids to the JSON file is left

themousepotato commented 5 years ago

@xypnox @thealphadollar Can we have it in /gh_login instead of /kwoc/gh_scraper ? The current structure is similar to that I guess.

thealphadollar commented 5 years ago

Done

On Sat 22 Dec, 2018, 14:00 Navaneeth Suresh <notifications@github.com wrote:

@xypnox https://github.com/xypnox @thealphadollar https://github.com/thealphadollar Can we have it in /gh_login instead of /kwoc/gh_scraper ? The current structure is similar to that I guess.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/183#issuecomment-449555007, or mute the thread https://github.com/notifications/unsubscribe-auth/AfStIDMIxjPNhKw2uff29a71XtjipnSQks5u7e2XgaJpZM4ZeAcN .