search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Send mentor mails #189

Closed TheLethalCode closed 5 years ago

TheLethalCode commented 5 years ago

The script for sending the mail is in kwoc/sendgrid_mail.py . Make sure to export the env variables of the sendgrid api. And I might have added one too many < br's > in the body of the email. Everything else should be fine. @themousepotato @Ayushk4 @thealphadollar

themousepotato commented 5 years ago

@TheLethalCode Please describe the changes that you've made. It'll be also helpful for the future. I'm unable to understand this at the moment. Haven't worked with this. Also, please remove other files which aren't part of this PR. This is reflecting some of the older commits,

themousepotato commented 5 years ago

Also, please either make it a new file or add a new function. This works only for sending mentor mails for mid evals. The script sendgrid_mail.py is general for sending mails automatically.

TheLethalCode commented 5 years ago

@themousepotato as far as I see only one file has been changed :/ . And I thought of making a new file, but pretty much evrything is the same. Only the 'main' and the file with the mail ids has to be changed. So I didnt see a point of creating a new file. And more over, this branch focuses on mentor mid evals, so I dont think there is much harm in changing, though as I said, the base template is the same. The script uses the mentor id and name hashing from mentor_unique_ids.json, and name and mail hash from projects.csv to generate the link for every mentor and send the email.

thealphadollar commented 5 years ago

@TheLethalCode I'll be using code from your PR, but not merging it.