Coming soon folder added

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018

https://kwoc.kossiitkgp.org

MIT License

0 stars 0 forks source link

Coming soon folder added #19

Closed nikhilch23 closed 5 years ago

nikhilch23 commented 5 years ago

Hey! i guess the problem is reolved now. Do check. @thealphadollar

thealphadollar commented 5 years ago

Great page <3 A few suggestions:

Remove unnecessary files from the folder.
Change the images in the background slideshow to something more relevant to KWoC.
Follow the pattern of app.py file inside the kwoc folder; so that this can be used in the same manner with gunicorn.
At the "we will get back to you page", redirect the user to main page after 5 seconds.
Make the ip_address of the app listen at "0.0.0.0"

cc/ @dibyadas @djbarnwal @nikhilch23

dibyadas commented 5 years ago

Awesome! @thealphadollar Can you make the server up and running with this as the landing page?

thealphadollar commented 5 years ago

@dibyadas I would wait for the changes to be made :) I also have to see if the form is a dummy one or actually working.

dibyadas commented 5 years ago

Definitely. That's what I meant. :+1:

nikhilch23 commented 5 years ago

Should i only replace the previous app.py with mine? or remove all the folders all together?

cc @thealphadollar @dibyadas

thealphadollar commented 5 years ago

No; do not remove anything! Keep your folder separate, just follow the pattern of kwoc/app.py for your app.py.

Please do not remove anything outside your folder.

nikhilch23 commented 5 years ago

@thealphadollar I have made the necessary changes. Do check.

djbarnwal commented 5 years ago

@nikhilch23 Please note that you should not send PRs from the master branch

thealphadollar commented 5 years ago

@nikhilch23

At the "we will get back to you page", redirect the user to main page after 5 seconds.
Make the ip_address of the app listen at "0.0.0.0"

@dibyadas I've a lab test tomorrow, I'll deploy tomorrow only. Once all the work is done :)

nikhilch23 commented 5 years ago

I have a test tomorrow morning. If someone is free, could you help me with the last issue that dhiraj has suggested? @xypnox @yashrsharma44 _

thealphadollar commented 5 years ago

@dibyadas What should be the time remaining?

sangeet259 commented 5 years ago

@thealphadollar Let's follow last years schedule.

thealphadollar commented 5 years ago

@sangeet259 Let's move it by 3 days forward for first two items of the schedule? We don't have a finalized coming soon page yet.

sangeet259 commented 5 years ago

@thealphadollar Yeah, that's better, shift it a bit.

yashrsharma44 commented 5 years ago

Hey, if the work is not done, I am willing to complete it @thealphadollar

thealphadollar commented 5 years ago

Please do @yashrsharma44. I would like you to work on a separate branch and make changes (after I've merged the changes done here).

I'll create an issue listing what all needs to be done before we go live.

thealphadollar commented 5 years ago

@kshitij10496 @djbarnwal I'm merging the PR and then @yashrsharma44 will be working further on it. I'm doing this since we need to speed up things; I hope you don't mind.