search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

End term patch #198

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

The gh_login names need to be removed from the server as well, so kwoc/remove_failed.py needs to be run.

themousepotato commented 5 years ago

@Ayushk4 Please add more instructions to the PR by stating the change in current method et al. Are we going to mail the students their unique link? :thinking:

Ayushk4 commented 5 years ago

We are sticking with generating hashkey and then mailing the students their respective end-eval-form, the end-eval address is something like kwoc.kossiitkgp.org/end-term/

themousepotato commented 5 years ago

I'm closing this @Ayushk4. Don't feel obligated. This is really messed up. Modifying .gitignore and making changes to the files that are not even tracked is not a good idea. Also, again reverting the modified changes in the .gitignore may confuse git. There are still changes to the ignored files. So, merging this PR won't make a difference to most of the files and which won't work as the way you tested in your host. If I merge this, the server will go down for sure. If I request changes, then git is not capable of editing history in a sweet manner IMHO.

I want you to send two PRs. One containing the files which are untracked and need changes(don't even dare to think of .gitignore :wink: ). I won't be merging this. Instead, I'll make the necessary changes in the server. Another one which I'll be merging which would contain a script to send mails(you can get it from @TheLethalCode 's unmerged PR after renaming the file.), a file containing the hashes which will serve as an input to the script, all helper scripts which you've used and the necessary edits to app.py et al.

dibyadas commented 5 years ago

@themousepotato @Ayushk4 Do discuss this out in #kwoc-backend until everyone's clear what they are doing so as to not waste anybody's effort.