search

kossiitkgp / kwoc-2018

Web app for Kharagpur Winter of Code, 2018
https://kwoc.kossiitkgp.org
MIT License
0 stars 0 forks source link

Add datalist to choose college #66

Closed themousepotato closed 5 years ago

themousepotato commented 5 years ago

Built on the top of https://github.com/kossiitkgp/kwoc/pull/63. Affecting #60.

themousepotato commented 5 years ago

Adding options for year is a simple fix. <datalist> also provides adding custom entries. If we want to add the entries which are not in the json to it, a function on POST will do. But, why do we want to do that? This can’t take invalid entries into account. Can we just collect from the output of registration those colleges? @thealphadollar 🤔

thealphadollar commented 5 years ago

My apologies, but I didn't understand what you tried to convey.

themousepotato commented 5 years ago

@thealphadollar I've updated my comment ;) Also, added options for the year of study.

thealphadollar commented 5 years ago

Well, can you just add a reminder to the form that if their college is not there they can mail us the name of the college and we'll add?

themousepotato commented 5 years ago

For sure.

On Sunday, November 25, 2018, Shivam Kumar Jha notifications@github.com wrote:

Well, can you just add a reminder to the form that if their college is not there they can mail us the name of the college and we'll add?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kossiitkgp/kwoc/pull/66#issuecomment-441424348, or mute the thread https://github.com/notifications/unsubscribe-auth/AgXlPnrM-cuCeIIk-LPmFRFCza0kh1QRks5uylbKgaJpZM4YxvU_ .

themousepotato commented 5 years ago

@xypnox Can you please look into it. Just add Can't find your college? No worries. Mail us and we'll add it. with a mailto link. I'm having UI issues :(

thealphadollar commented 5 years ago

We're going ahead with this now. @xypnox create a PR when you are free.