search

kosslab-kr / linux-perf

:rocket: perf contribution (mirrored from git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git)
Other
16 stars 8 forks source link

perf diff: Introduce the new rules of colored printing of delta. #147

Open ppiyakk2 opened 8 years ago

ppiyakk2 commented 8 years ago

As you know, there are the common colored printing of percents so overhead(%) can be colored with the rule. But Delta means difference percents from percents of overhead between two files e.g. perf.data and perf.data.old. Although the rule is for overhead(%), Delta value also follow the same rule.

So, I think that it would be better to use the new colored rule for the Delta as below.

Increament: background colored in red (e.g. +0.50%) Decrement: colored in blue (e.g. -5.50%) Same: default color (e.g. +0.00%)

Instead of percent_color_snprintf() function, use new delta_color_snprintf() function.

Signed-off-by: SeongSoo Cho nexusz99@gmail.com Cc: Namhyung Kim namhyung@kernel.org Cc: Jiri Olsa jolsa@kernel.org Cc: Taeung Song taeung@kosslab.kr

DongDongKim commented 8 years ago

I also think so. Using the new colored rule for the Delta can help us to realize variation