kosslab-kr / linux-perf

:rocket: perf contribution (mirrored from git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git)
Other
16 stars 8 forks source link

perf config: Fix a bug about permission checking state of config file #149

Open wookje opened 8 years ago

wookje commented 8 years ago

perf_config_set__init() check state of user config file before opening it. But there is a bug when checking uid and euid of current user. Although current user have superuser permission, a error occurs as below.

Before:

user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig

user01@localhost:~/linux-perf/tools/perf/util$ sudo perf config --list Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it. Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it.

So, Fix it allowing a user who have superuser permission to open user config file.

After:

user01@localhost:~$ ls -l ~/.perfconfig -rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig

user01@localhost:~$ sudo perf config --list annotate.hide_src_code=false report.queue-size=0 tui.report=on colors.top=red, default

Cc: Taeung Song taeung@kosslab.kr Cc: Namhyung Kim namhyung@kernel.org Cc: Jiri Olsa jolsa@kernel.org Signed-off-by: Wookje Kwon aweee0@gmail.com

DongDongKim commented 8 years ago

How did you amend it? Why would you be possible without root authority?