search

kosta / gloomhaven-stacks

Tracker for your Gloomhaven Event and Quest cards
https://kosta.github.io/gloomhaven-stacks/
Other
3 stars 1 forks source link

draw random battle goals for the entire party #13

Closed signed closed 6 years ago

kosta commented 6 years ago

I'm not a huge fan of the drawDistinctBattleGoals implementation. It could run into an infinite loop if count > array length and will get slower the more cards you draw. I would prefer if you could fill an array, shuffle it and slice the first n cards.

Currently, these are just number, which is fine for us and for now. However, I'd love to make this generally suitable. But for that, we'd need a settings dialog. And maybe only reveal one players battle goal at a time etc. Consider these feature requests :)

signed commented 6 years ago

Can you please post the link to the community battle goals you found?

kosta commented 6 years ago

Unfortunately, they were only sent to me by email and I'm not sure whether we're allowed to publish them. I'll ask for permission. I can send them by email in the meantime but please don't publish in the repo.

kosta commented 6 years ago

Looks good!