kosta / gloomhaven-stacks

Tracker for your Gloomhaven Event and Quest cards
https://kosta.github.io/gloomhaven-stacks/
Other
3 stars 1 forks source link

Add cards in bring event to conclusion #15

Closed signed closed 6 years ago

kosta commented 6 years ago

Nice!

Very good use of React with props.children, I would not have though of that but that makes perfect sense and tickles my brain cells in good ways. I guess this is a major part in writing re-usable components.

Also: Good work with making this flexboxes. I reallty need to brush up my CSS!

Feature Request: Please add some padding so the flex boxes dont look so cramped.

signed commented 6 years ago

Another react concept that I find interesting to be DRY are higher order components. Not sure if I can apply them here, but good to know they exist.

kosta commented 6 years ago

Wrap, wrap, wrap! ;)

signed commented 6 years ago

padding added