kosta
commented
5 years ago This look really great! :D
Closed signed closed 5 years ago
kosta
commented
5 years ago This look really great! :D
kosta
commented
5 years ago Isaac posted the fonts used here https://boardgamegeek.com/thread/1733586/files-creation
I think the font for the heading is Pirata One: https://fonts.google.com/specimen/Pirata+One
Do you think you could use that font?
Btw I looked at the gallery and it looked awesome! :D
signed
commented
5 years ago @kosta I think this is ready for review/testing/feedback.
kosta
commented
5 years ago Thank you for your hard work! I think the layout is a bit weird but we're both not UI designers.
I love it! ❤️
Are you using the gloomhaven fonts? They're not showing up in my browser.
signed
commented
5 years ago If you have an idea for the layout let me know. Just tested the fonts in chrome and firefox, they show up for me.
kosta
commented
5 years ago ~Regarding the fonts: My browser dev console says~
~> Request to access cookie or storage on “https://lh3.googleusercontent.com/u/0/d/19x3kdXZF2oEME3WipHeAXISfWkGtgmEA=w1440-h766-iv1” was blocked because it came from a tracker and content blocking is enabled.~
~So please disregard :)~
Edit: My Firefox Nightly loads the fonts but does not display them. My Safari loads and displays them. I think it's probably a Firefox Nightly issue, so please disregard
kosta
commented
5 years ago Fonts look good in "normal" Firefox, so all is well!
kosta
commented
5 years ago One more layout thing: Can you make the checkbox somewhat more obvious? I missed it until I saw it referenced in the code...
Also, I would like to merge this Wednesday if you're ok with this, so we can use it in our game night. Any unresolved items can be fixed in follow-up requests. Would you be ok with that?
signed
commented
5 years ago Can you make the checkbox somewhat more obvious?
I removed them :). Have a look if this is better now. Merging before game night on Wednesday is fine with me.
kosta
commented
5 years ago This looks great and follows my intuition on choosing a battle goal card. Just click on it!
Can you make the box shadow effect on the selected card stronger / more obvious? Maybe add a bit of color?
Other than that, this is awesome! I like the bigger "player" buttons as well.
Do you plan to improve the ids before Wednesday? Otherwise, this I would merge this as soon as the box shadow is done.
About the IDs: what do you think of simple "string" ids? Just use "271" etc. for the card ids, but "Satire 12" for the Satire Gaming battle goals? That should be ~much~ a bit simpler to implement.
signed
commented
5 years ago Can you make the box shadow effect on the selected card stronger / more obvious? Maybe add a bit of color?
I did not change the shadow effect, but added a blur for the not picked battle goal. Does this help?
About the IDs: what do you think of simple "string" ids? Just use "271" etc. for the card ids, but "Satire 12" for the Satire Gaming battle goals? That should be much a bit simpler to implement.
Maybe a bit simpler, but unless you favor a formatted string I'd go with the extra type. Regardless the way we decide on, it will not happen till tomorrow. Feel free to merge if you think the solution works.
signed
commented
5 years ago One thing that just come to my mind, isn't there a rule where you can draw a 3rd battle goal if you do not want to take on of the initial two? The 3rd one you have to take? If that is the case, there is some more coding to do :)
kosta
commented
5 years ago Yeah I think the "draw 3rd battle goal" is one of our special house rules...
Ok sounds good I'll test and merge
kosta
commented
5 years ago Yeah I think the "draw 3rd battle goal" is one of our special house rules...
Ok sounds good I'll test and merge.
I replaced the vanilla battlegoal images with a css composite. This is a preparation for the community battle goals. Can you give some feedback if this goes into the right direction?