search

kosta / gloomhaven-stacks

Tracker for your Gloomhaven Event and Quest cards
https://kosta.github.io/gloomhaven-stacks/
Other
3 stars 1 forks source link

Composite card identifier #35

Closed signed closed 5 years ago

kosta commented 5 years ago

Sorry I forgot about reviewing this and will do so tomorrow (I hope)

signed commented 5 years ago

There is still a bug in the store/load logic in the battle goals I have to fix. Maybe tomorrow.

kosta commented 5 years ago

Ok once you're done let me know and I'll have another look.

signed commented 5 years ago

@kosta please have another look For now I'll leave the honor to add the CardIdentifier in the rest of the code to you :).

kosta commented 5 years ago

I think this looks good and I will merge.

Could you add some more explaining comments around storing and loading state in partyBattleGoals.tsx? At the moment I don't can't take the time to really comprehend this which hints that this is not obvious enough :)