kosta1221 / puppeteer-in-lambda-container-demo

Source code for my medium article about running puppeteer in a container function.
13 stars 2 forks source link

Not issue #1

Open Nigrimmist opened 2 years ago

Nigrimmist commented 2 years ago

Just would like to say Thank you for this repo! I spent 3 days to trying run simple code on puppeteer on AWS lambda and only your article on Medium worked like a charm!

Not sure, is it a bug or something was changed from aws side for last year, but your docker did not worked from the box in my case. The reason was in last CMD call. Worked for me :

CMD [ "index.lambdaHandler" ]

ENTRYPOINT ["/lambda-entrypoint.sh", "/var/task/index.lambdaHandler"] also, commented : //waitUntil: ["networkidle2"], //timeout: 20000, as lambda hangs with it.

But maybe it is because I am deploying from visual studio and used C# project as type of project. if you can confirm, that your version is till works fine for you - will be great.

Anyway, all other stuff works fine. Have a good day!

theodopolopodous commented 1 year ago

Agreed, thank you @kosta1221

Quick question: If you were doing this today, are there any improvements you'd investigate?