search

kosta777 / parallel-genomeseq

Parallelization of popular genome sequencing algorithms
4 stars 1 forks source link

Segmentation Error in SWAligner #4

Closed huanglangwen closed 4 years ago

huanglangwen commented 4 years ago

Call Stack:

SWAligner::calculateScore swaligner.cpp:27
main main.cpp:99

https://github.com/kosta777/parallel-genomeseq/blob/master/src/aligner/swaligner.cpp#L27 I guess that's due to the dynamically assigned matrix. We really need a modern style matrix library to avoid this.

huanglangwen commented 4 years ago

Second issue: https://github.com/kosta777/parallel-genomeseq/blob/master/src/aligner/swaligner.cpp#L48 matrix[i - 1][j - 1] is invalid when i=1, j=0. @kosta777