kostafey / ejc-sql

Emacs SQL client uses Clojure JDBC.
279 stars 29 forks source link

update broke auto-completion on spacemacs-develop #115

Closed pepperblue closed 4 years ago

pepperblue commented 4 years ago

After receiving latest package updates on spacemacs-develop auto-completion is broken: Info from Messages-buffer is:

Receiving database structure... [2 times] Wrong type argument: stringp, nil in wrapped Clojure->Elisp function: ejc_sql.structure$complete_auto_complete@24a6df87 elisp: (ejc-complete-auto-complete "hio_base.sql" 13)

I was trying to get more debug information with (setq debug-on-error t) but there was no Backtrace-buffer available ...

OS is Fedora 31 Emacs is 26.3 Spacemacs is latest on develop-branch Java is openjdk 11.0.5 ejc-sql ist 20191125.14-43 Database is Postgresql 9.3 Driver is 42.2.8

pepperblue commented 4 years ago

It seems that auto-comlete is only broken for db-entities (tables, columns and so on). Auto-complete for SQL-keywords is working at least partially ...

pepperblue commented 4 years ago

Using doom-emacs and a local database-connection I get a different error with the following backtrace: backtrace-buffer.txt

kostafey commented 4 years ago

@pepperblue, could you try the latest updated version, please.

pepperblue commented 4 years ago

Errors are gone! I tested against two Postgres-DBs with different results:

A remote DB with lots of tables and data (running Postgresql-Version 9.3): auto-complete is working as expected

A local DB - for testing purposes only - with only one table with two columns containing no data (running Postgresql-Version 11.6): I nearly get no candidates for table and columns in auto-complete-popup (sporadically the table is shown but never the columns)

kostafey commented 4 years ago

@pepperblue, please try with the current update.

pepperblue commented 4 years ago

For local test-DB auto-complete is working as expected now, but for remote DB auto-complete is blocking input: ejc-error.txt

kostafey commented 4 years ago

@pepperblue, please try the latest one.

pepperblue commented 4 years ago

Auto-complete now is working for me and postgres. Thank you for the fix!