kostafey / ejc-sql

Emacs SQL client uses Clojure JDBC.
279 stars 29 forks source link

Can ejc-sql support sql.el's sql-interactive-mode? #116

Open stardiviner opened 4 years ago

stardiviner commented 4 years ago

Is ejc-sql possible to provide code complete for sql.el's sql-interactive-mode buffer?

stardiviner commented 4 years ago

Here is my temporary solution:

(defun ejc-sql-interactive-mode-setup ()
  "Setup ejc-sql completion in `sql-interactive-mode'."
  (interactive)
  (call-interactively 'ejc-connect)
  (ejc-sql-mode)
  (auto-complete-mode 1)
  (ejc-ac-setup))
(add-hook 'sql-interactive-mode #'ejc-sql-interactive-mode-setup)

WDYT?

kostafey commented 4 years ago

@stardiviner, how do you plan to connect to the desired database? Are you going to use sql-mode connection engine? Maybe this ad-hoc workaround will be ok for you. But for future development, I think it's worth to provide ejs-sql own DB connection for sql-interactive-mode.

stardiviner commented 4 years ago

I agree, thanks that this is on the ejc-sql planning list.