Update dependencies - Githubissues

roelnoort commented 3 years ago

Hi,

I am using this package. Right now some of the dependencies are old so I'd like to update them to the latest versions.

My suggested changes to package.json are:

      "dependencies": {
        "amqplib": "0.7.1",
        "bluebird-retry": "^0.11.0",
        "debug": "4.3.1",
        "lodash.includes": "^4.3.0",
        "lodash.map": "4.6.0",
        "lodash.pickby": "^4.6.0",
        "require-dir": "1.2.0",
        "unhandled-rejection": "^1.0.0"
      },
      "devDependencies": {
        "@feathersjs/express": "^4.5.11",
        "@feathersjs/feathers": "^4.5.11",
        "ava": "^0.25.0",
        "bluebird": "3.7.2",
        "eslint": "7.23.0",
        "eslint-config-airbnb": "18.2.1",
        "eslint-plugin-import": "2.22.1",
        "feathers-mongoose": "^8.3.1",
        "mongoose": "5.12.2",
        "node-helpers": "1.1.8",
        "shelljs": "0.8.4"
      }

You might notice, that apart from version updates, I also removed the feathers-hooks package. This does not appear to be used anywhere.

In addition, the node-helpers would also need to be updated. I created an Issue for that repo with suggested changes as well.

All tests still pass.

I am also happy to create a pull request if that is helpful but frankly I'm not too sure how to do that precisely. I guess I have to fork your repo and create a pull request from there...

Best, Roel

kostia-official commented 3 years ago

Hello, Roel, if you create a PR I can merge and publish these updates.

roelnoort commented 3 years ago

Sure, I'll do this as soon as you merge the PR for node-helpers as this repo depends on that one.

roelnoort commented 3 years ago

Hi Kostiantyn thanks for accepting my PR on node-helpers. I just created one for feathers-amqp-events as well. Best, Roel

kostia-official commented 3 years ago

Published, hope everything works

kostia-official / feathers-amqp-events

Update dependencies #6