kostiantyn-nemchenko / ansible-role-patroni

:elephant: Ansible Role for Patroni
https://galaxy.ansible.com/kostiantyn-nemchenko/patroni
MIT License
68 stars 44 forks source link

Versioning Content #84

Closed wilfriedroset closed 4 years ago

wilfriedroset commented 4 years ago

One of the best practice recommended in ansible galaxy documentation is to use versioning content. Doing so allow users to pin the version of the role in order to avoid surprise in production during the next ansible-galaxy install. This require only to add tags to commit which is not done at the moment in this repository.

Here is an example of my side project requirements.yml

---
roles:
  - name: brianshumate.consul
    version: v2.5.4
  - name: kostiantyn-nemchenko.patroni

collections: []

As you can see I can pin the version I want yo use for brianshumate.consul but not for kostiantyn-nemchenko.patroni due to missing tags.

What do you think about adding 1.0.0 tag to the latest commit?

kostiantyn-nemchenko commented 4 years ago

Hi, I'm aware of the best ansible galaxy practices. Wanted to add some documentation about role variables before releasing the first version, but I'm fine to document them later. The 1.0.0 tag has been added. Thanks for your input.

wilfriedroset commented 4 years ago

thank you 🙏