Authorize string for width and height props

kostimarko / rn-content-loader

a react native content loader without expo using react native svg

MIT License

82 stars 25 forks source link

Authorize string for width and height props #5

Closed ACHP closed 5 years ago

ACHP commented 5 years ago

Hi, thank you for this library. This is a tiny PR to change the PropTypes of both width and height since react-native-svg use PropTypes.oneOfType([PropTypes.string, PropTypes.number]).

Not a big deal, but a warning appears when I use width='100%' ....And I don't like warnings ... 😂

kostimarko commented 5 years ago

Thanks! Looks good to me. I will update the library later tonight. Thanks a ton.