search

kostimarko / rn-content-loader

a react native content loader without expo using react native svg
MIT License
82 stars 25 forks source link

viewbox support #7

Closed nazarireza closed 5 years ago

nazarireza commented 5 years ago

Hey kostimarko, Can you check this out?

kostimarko commented 5 years ago

@nazarireza It looks good. Having never used the viewBox portion of SVG, I'm curious if you would ever want to set the top and left position or have the height and width of the viewbox be different the the height and width of the animated svg.

I'll update the library later tonight. Thanks a bunch!

nazarireza commented 5 years ago

@nazarireza It looks good. Having never used the viewBox portion of SVG, I'm curious if you would ever want to set the top and left position or have the height and width of the viewbox be different the the height and width of the animated svg.

I'll update the library later tonight. Thanks a bunch!

Thank you, When you design content-loader with specific width and height, and then you use in smaller dimension, you need to use "ViewBox" props otherwise the content cropped.