search

kostmo / circleci-failure-tracker

A log analyzer for CircleCI. Note that this project is now hosted at pytorch/dr-ci
https://github.com/pytorch/dr-ci
5 stars 2 forks source link

Specificity gets confused about tests which purposely trigger compile errors #32

Closed ezyang closed 4 years ago

ezyang commented 5 years ago

In https://circle.pytorch.org/commit-details.html?sha1=6d7cc4cc7744f646a397ceb9e887e0f8ad519850 the compile error regex matches a useless "ERROR:sccache::server: Compilation failed" line, when "ERROR: test_compilation_error_formatting (main.TestCppExtension)" is a much better line (it also has a pattern, but it is less specific). Does this mean the test matcher should have higher specificity than build error?

kostmo commented 5 years ago

Does this mean the test matcher should have higher specificity than build error?

Yep, that seems right.