kostmo / circleci-failure-tracker

A log analyzer for CircleCI. Note that this project is now hosted at pytorch/dr-ci
https://github.com/pytorch/dr-ci
5 stars 2 forks source link

app: Wrap build sections with details tag #69

Closed seemethere closed 4 years ago

seemethere commented 4 years ago

Allows for build sections to wrapped in a <details> tag to reduce the spam from the comment itself.

Do note: This is my first time working in Haskell so I'm not entirely sure if I got the syntax right.

Signed-off-by: Eli Uriegas eliuriegas@fb.com

kostmo commented 4 years ago

Can you try posting a manually-crafted comment in this PR the embeds a multi-line-code-block (triple backticks) inside the \<details> tag? I wasn't able to get it to work; it seems that markdown formatting gets ignored when inside an html tag?

E.g., I can't seem to put this:

foo
bar

inside this:

open me ``` foo bar ```
kostmo commented 4 years ago

Oooh I figured it out:

open me
foo
bar
seemethere commented 4 years ago

Yup that'd look like:

I contain a code block ```python class Codeblock(object): def __init__(self, the_stuff): self.the_stuff = the stuff ```
This might be a nested code block ![never gonna give you up](https://media.giphy.com/media/Vuw9m5wXviFIQ/giphy.gif)
kostmo commented 4 years ago

Seems like the trick is leaving a blank line in between the html tags and the markdown?

seemethere commented 4 years ago

Yup, I think I may need to modify the code to add a newline between the code blocks and the ending </details> tag

seemethere commented 4 years ago

Just modified my PR to do that