kostub / iosMath

Beautiful math equation rendering on iOS and MacOS
MIT License
1.37k stars 234 forks source link

Fixes a check for generating a large op with with scripts under and o… #125

Closed cupojoe closed 5 years ago

cupojoe commented 5 years ago

…ver when in fractions and other displays not in the main level

@kostub This seems to work fine with all the generated math in the example app. The use case is to have the following:

Screen Shot 2019-08-28 at 8 44 17 PM

instead of this:

Screen Shot 2019-08-28 at 8 46 03 PM
cupojoe commented 5 years ago

@kostub any chance you could take a look at this one?

kostub commented 5 years ago

Isn’t this only supposed to be the case in display style?

cupojoe commented 5 years ago

Not according to our subject matter expert. Bounds can go either below/above or next to the operator but should be consistent. And for limits, seems to be the case they always go below.

cupojoe commented 5 years ago

@kostub does it make sense? Or do you think this be an option? I can think of a way to add this an option.

kostub commented 5 years ago

I checked on ShareLatex and Pages (on Mac) and the current implementation is correct:

I tried these two variations:

\[\frac{\lim_{x \rightarrow \infty}}{x+1}\]
\[\frac{\displaystyle{\lim_{x \rightarrow \infty}}}{x+1}\]

This displays as:

image

as expected. I believe both options already work correctly.

cupojoe commented 5 years ago

This makes sense. I went back to our SME, and she is ok with it being on the side for other positions outside of the display line. I wonder why this choice of render. I will close for now, hopefully the design team won't get too hung up on this.