Increased the set count from 8 to 12 so that each key can be mapped chromatically to a unique set element

kosua20 / MIDIVisualizer

A small MIDI visualizer tool, using OpenGL

MIT License

1.06k stars 140 forks source link

Increased the set count from 8 to 12 so that each key can be mapped chromatically to a unique set element #130

Closed PrimateCoder closed 1 year ago

PrimateCoder commented 1 year ago

This also makes it more practical to use the same color for all effects when assigning color per key.

Existing key color mappings will need a one time update, but I believe the new chromatic mapping is more logical.

PrimateCoder commented 1 year ago

The proof is in the pudding! I needed this change in order to make this video 🙂:

https://youtu.be/q9h1RxYRx8k

kosua20 commented 1 year ago

Thank you for this pull request! This makes sense, I've merged the PR and adjusted a few things: I've added a new Set definition mode (Chromatic) instead of replacing the old mode, to preserve backward compatibility.

kosua20 commented 1 year ago

This is now availble in the latest 7.1 release ! Thank you once again :)