search

kosua20 / MIDIVisualizer

A small MIDI visualizer tool, using OpenGL
MIT License
1.07k stars 140 forks source link

When I input the midi,the performance is wrong. #42

Closed w86102711 closed 4 years ago

w86102711 commented 4 years ago

If whole music is the same tempo,it will no problem. But when you change the speed like Ritenente and Accelearando , the performance is wrong.

w86102711 commented 4 years ago

ezgif com-video-to-gif (1) ezgif com-video-to-gif

kosua20 commented 4 years ago

Hello, thank you for using MIDIVisualizer, and for reporting this issue. Could you send me a MIDI file where this occurs, so that I can reproduce the issue and try to fix it? Thank you!

w86102711 commented 4 years ago

beastars-pf-solo .zip

Hello, thank you for using MIDIVisualizer, and for reporting this issue. Could you send me a MIDI file where this occurs, so that I can reproduce the issue and try to fix it? Thank you!

ekuiter commented 4 years ago

Can confirm this issue, minimum example attached (a simple tempo change suffices).

grafik

grafik

example.zip

ekuiter commented 4 years ago

In my fork, I fixed this issue by using libmidi from Linthesia (which is based on an old Synthesia version). This way, we can handle tempo changes correctly. (Sadly, libmidi still assumes time signature 4/4, so horizontal lines are wrong. This is another issue though.)

grafik

kosua20 commented 4 years ago

Hello, I'm very happy to say that I've finally had a bit of time to allocate to MIDIVisualizer, and the timing issues are now fixed (hopefully for good this time)! I've checked MIDIVisualizer on the file you and ekuiter have shared, thank you for your help once again!

The latest v5.1 version has now been released with these fixes.